Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache-create for updated LLVM StringExtras.h #172

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix cache-create for updated LLVM StringExtras.h #172

merged 1 commit into from
Jul 19, 2023

Conversation

dstutt
Copy link
Member

@dstutt dstutt commented Jul 19, 2023

StringExtras.h no longer included transitively.
Update unittest to add the include

@dstutt
Fix cache-create for updated LLVM StringExtras.h
db55ba9 
StringExtras.h no longer included transitively.
Update unittest to add the include
Flakebi
Flakebi approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me (though I don’t have the power to merge it).

@dstutt
Copy link
Member Author

dstutt commented Jul 19, 2023

This is required to fix LLPC test actions

This was referenced Jul 19, 2023
Closed
Merged
trenouf
trenouf approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@trenouf trenouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amdvlk-admin
Copy link
Collaborator

Test summary for commit db55ba9

CTS tests (Failed: 0/211362)
  • Built with version 1.3.3.1
    • Rhel 9.0, Gfx10
    • Passed: 35147/70459 (49.9%)
    • Failed: 0/70459 (0.0%)
    • Not Supported: 35312/70459 (50.1%)
    • Warnings: 0/70459 (0.0%)
    Ubuntu 22.04, Navi3x
    • Passed: 39026/70459 (55.4%)
    • Failed: 0/70459 (0.0%)
    • Not Supported: 31433/70459 (44.6%)
    • Warnings: 0/70459 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 39058/70444 (55.4%)
    • Failed: 0/70444 (0.0%)
    • Not Supported: 31386/70444 (44.6%)
    • Warnings: 0/70444 (0.0%)

@trenouf trenouf merged commit 5fd987a into GPUOpen-Drivers:dev Jul 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trenouf trenouf trenouf approved these changes

@Flakebi Flakebi Flakebi approved these changes

@WenqingLiAMD WenqingLiAMD Awaiting requested review from WenqingLiAMD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstutt @amdvlk-admin @trenouf @Flakebi