Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX12] Copy-paste error in SSSR resource name #2

Open
vilbeyli opened this issue Apr 25, 2022 · 0 comments
Open

[DX12] Copy-paste error in SSSR resource name #2

vilbeyli opened this issue Apr 25, 2022 · 0 comments

Comments

@vilbeyli
Copy link

https://github.com/GPUOpen-Effects/FidelityFX-SSSR/blob/master/sample/src/DX12/Sources/SSSR.cpp#L494

m_sampleCount[0].Init(m_pDevice, "Reflection Denoiser - Variance 0", &sampleCountDesc, D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE, nullptr);
m_sampleCount[1].Init(m_pDevice, "Reflection Denoiser - Variance 1", &sampleCountDesc, D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE, nullptr);

should be

m_sampleCount[0].Init(m_pDevice, "Reflection Denoiser - Sample Count 0", &sampleCountDesc, D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE, nullptr);
m_sampleCount[1].Init(m_pDevice, "Reflection Denoiser - Sample Count 1", &sampleCountDesc, D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE, nullptr);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vilbeyli