New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tonemappers 'abs' are useless #20

Open

GregSlazinski opened this issue Sep 6, 2021 · 0 comments

GregSlazinski commented Sep 6, 2021

https://github.com/GPUOpen-LibrariesAndSDKs/Cauldron/blob/master/src/DX12/shaders/Tonemappers.hlsl#L75
https://github.com/GPUOpen-LibrariesAndSDKs/Cauldron/blob/master/src/DX12/shaders/Tonemappers.hlsl#L77

There are 2 abs, which I believe are useless since ratio should always be in 0..1 as long as colors are >=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment