Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Username Display Bug #179

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

emilyliublair
Copy link
Collaborator

Update Username Display Bug

Issue Number(s): #174

What does this PR change and why?
on initial sign in, user's name will be updated accordingly in the settings page

Checklist

  • Requirements have been implemented
  • Acceptance criteria is met
  • Database schema docs have been updated or are not necessary
  • Relevant reviewers (EM) have been assigned to this PR

Critical Changes

Related PRs

PR Number(s):

How To Test

  1. sign up with different name
  2. see updated name accurately displayed in settings page and nav drop down

@emilyliublair emilyliublair self-assigned this Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for canine-assistants ready!

Name Link
🔨 Latest commit da3940b
🔍 Latest deploy log https://app.netlify.com/sites/canine-assistants/deploys/6601e6d7aa94040008048afc
😎 Deploy Preview https://deploy-preview-179--canine-assistants.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@laurenmcp laurenmcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great emily!

setName(session.user.name);
}
}, [session])
fetch(`/api/users/${session?.user._id}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if session and session.user != null/undefined before fetching. Another way to do it is check if status != "loading" and then add status to the dependency array. status comes from useSession() hook

@emilyliublair emilyliublair changed the base branch from dev to alexa-speedrun April 15, 2024 22:25
@emilyliublair emilyliublair changed the base branch from alexa-speedrun to dev April 15, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants