Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GT++ circuits (bio and breakthrough) #16539

Open
4 tasks done
SKProCH opened this issue Jun 16, 2024 · 6 comments · May be fixed by GTNewHorizons/GT5-Unofficial#3389
Open
4 tasks done

Remove GT++ circuits (bio and breakthrough) #16539

SKProCH opened this issue Jun 16, 2024 · 6 comments · May be fixed by GTNewHorizons/GT5-Unofficial#3389
Labels
Mod: GT GregTech and its (former) addons Suggestion

Comments

@SKProCH
Copy link

SKProCH commented Jun 16, 2024

Your GTNH Discord Username

skproch

Your Pack Version

2.6.0

Your Proposal

GT++ adds the two new sets or programmed circuits: bio circuits and breakthrough circuits).

Bio circuits has the ~100 recipes in all modpack total.
Breakthrough also has not so much recipes.
Most of this is for dehydrator, chem plant or other GT++ multiblocks which doesn't use original GT programmed circuits at all.

I've asked about this in the discord and probably answer "why this circuits are exists" is:

AFAIK the bio/breakthrough ones are from an ancient era when fake circuits didn't exists, and they were making the recipes slightly more expensive. (Still a NC item though, so just a one-time cost per machine.)

My proposal is to eventually remove this unnecessary circuits.

Your Goal

This circuits are just a mess, since we already have ghost circuits we actually doesn't need the GT++ ones in the pack, since all existing recipes can be fit into usual programmed circuits.

Your Vision

My vision is to replace the GT++ ones in the recipes and on a world load (like a migration), if possible.

Also, alternative proposal from the discord is:

Something that could potentially be done is add an entirely new type of circuit, redo all the existing recipes using the new circuit type in some sensible distribution (what exactly that means and how to enforce it would have to be determined), and then for one release cycle keep both old and new recipes at the same time to give people time to switch. Then yeet the old recipes/circuits.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this change please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
  • I understand this change request may not attract enough attention and thus not be implemented.
  • I understand this change request may be rejected due to other community members think it's inappropriate.
  • I believe this feature would make the pack better.
@SKProCH SKProCH added Status: Triage Issue awaiting triage. Remove once this issue is processed Suggestion labels Jun 16, 2024
@chochem
Copy link
Member

chochem commented Jun 16, 2024

sounds like breaking many, many setups for very little gain to me.

@chochem chochem added Mod: GT GregTech and its (former) addons and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Jun 16, 2024
@Reflex18
Copy link
Contributor

This is even less of an issue since you can just add fake circuits to any machine for free.

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the Status: Stale Automatically close this issue in 2 weeks if there are no new responses label Sep 15, 2024
@SKProCH
Copy link
Author

SKProCH commented Sep 15, 2024

Seems like this is now can be done via postea (my attempts to patch forge parts isn't succeseful anyway). As far as i can get, we just hide the old gt++ circuits, replace it inside a recipes with the gt ones, and make a postea migration.

@HoleFish
Copy link

the real hard work is the "just"

@github-actions github-actions bot removed the Status: Stale Automatically close this issue in 2 weeks if there are no new responses label Sep 15, 2024
@NotAPenguin0
Copy link
Contributor

The postea transformer is not very hard, I can take care of that since I've written one before. The main work would be checking all the new recipes for conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: GT GregTech and its (former) addons Suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants