From 9a37ede6f87bfffd1eef6f70fbed5848876b1b52 Mon Sep 17 00:00:00 2001 From: James Parker Date: Wed, 25 Sep 2024 11:03:51 -0400 Subject: [PATCH 1/3] Test regression CI comments --- .github/workflows/ci-pr-bench.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci-pr-bench.yml b/.github/workflows/ci-pr-bench.yml index aef43678c..62a8c14b2 100644 --- a/.github/workflows/ci-pr-bench.yml +++ b/.github/workflows/ci-pr-bench.yml @@ -158,3 +158,4 @@ jobs: repo: context.repo.repo, body: require('fs').readFileSync('${{ env.COMMENT }}').toString() }); + From b6cc71203d21c98888766eab0dec90bcd762b5a7 Mon Sep 17 00:00:00 2001 From: James Parker Date: Wed, 25 Sep 2024 11:07:06 -0400 Subject: [PATCH 2/3] Revert "Test regression CI comments" This reverts commit 9a37ede6f87bfffd1eef6f70fbed5848876b1b52. --- .github/workflows/ci-pr-bench.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci-pr-bench.yml b/.github/workflows/ci-pr-bench.yml index 62a8c14b2..aef43678c 100644 --- a/.github/workflows/ci-pr-bench.yml +++ b/.github/workflows/ci-pr-bench.yml @@ -158,4 +158,3 @@ jobs: repo: context.repo.repo, body: require('fs').readFileSync('${{ env.COMMENT }}').toString() }); - From ed621dc71aa978d090241d6af370d01ecbeadd42 Mon Sep 17 00:00:00 2001 From: James Parker Date: Wed, 25 Sep 2024 11:19:44 -0400 Subject: [PATCH 3/3] Try upgrading actions/github-script to v7 --- .github/workflows/ci-pr-bench.yml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci-pr-bench.yml b/.github/workflows/ci-pr-bench.yml index aef43678c..47a43e0e0 100644 --- a/.github/workflows/ci-pr-bench.yml +++ b/.github/workflows/ci-pr-bench.yml @@ -1,11 +1,5 @@ name: CI Benchmarks -permissions: - id-token: write - contents: read - issues: write - pull-requests: write - on: pull_request: branches: @@ -148,11 +142,10 @@ jobs: tests/compare-benchmarks.py ${{ env.BASE_DATA }} ${{ env.PR_DATA }} >> ${{ env.COMMENT }} - name: 'Comment PR' - uses: actions/github-script@v4.0.2 + uses: actions/github-script@v7 with: - github-token: ${{ secrets.GITHUB_TOKEN }} script: | - github.issues.createComment({ + github.rest.issues.createComment({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo,