Skip to content

CI tag matching patterns are incorrect #1829

@sauclovian-g

Description

@sauclovian-g

We discovered the hard way in SAW this week (see GaloisInc/saw-script#2267) that the patterns accepted in the on: push: tags: field of CI yaml files are "globs" and not regexps, and in particular don't support grouping with ( ).

(I say "globs" because they aren't globs either, they apparently do support [0-9]+ and other non-glob regexp constructs.)

Both ci.yml and docs.yml should probably get a change like the one in the above saw-script PR:

-    tags: ["[0-9]+.[0-9]+(.[0-9]+)?"]
+    tags:
+      - "[0-9]+.[0-9]+"
+      - "[0-9]+.[0-9]+.[0-9]+"

Metadata

Metadata

Assignees

No one assigned

    Labels

    CIContinuous integrationbugSomething not working correctly

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions