Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] change default indexes to lowercase #44

Open
remluben opened this issue Oct 15, 2013 · 3 comments
Open

[Proposal] change default indexes to lowercase #44

remluben opened this issue Oct 15, 2013 · 3 comments

Comments

@remluben
Copy link

Hello, I am currently using the Browscap class within one of my projects and when installing it the first time, I was wondering why the default indexes where camelcase instead of lowercase.

Somehow I expected the indexes to be lowercase as the php get_browser() function returns them as lowercase too.

Is there a special reason why the default was chosen not to be lowercase?

If this propasal seems weird or senseless to you, please do not hesitate to trash it.

@andyfeller
Copy link

This is supported by setting the lowercase properties to true whenever you instantiate the object

    /**
     * Flag to enable only lowercase indexes in the result.
     * The cache has to be rebuilt in order to apply this option.
     *
     * @var bool
     */
    public $lowercase = false;

It would be nice to mention this in the documentation for drop-in get_browser() support.

@mimmi20
Copy link

mimmi20 commented Apr 8, 2014

Information is added to the wiki

@andyfeller
Copy link

Awesome! Thanks ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants