Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 #57

Closed
adelowo opened this issue Jul 6, 2017 · 0 comments
Closed

Version 2 #57

adelowo opened this issue Jul 6, 2017 · 0 comments
Assignees

Comments

@adelowo
Copy link
Collaborator

adelowo commented Jul 6, 2017

While the library works as expected, the motivation for a 2.0 are

  • PHP version support (I created Bump the minimum supported PHP version #36 last year but had to back down a bit).. 2.0 is >=7.0

  • Storage abstraction : We currently maintain our own abstractions, interfaces and a local adapter but there are battle tested community packages that have stood out over the years.. Flysystem and Gaufrette comes to mind.. Tracking issues -> Gaufrette Dependency #1 ... Plus we get access to multiple adapters, Flysystem for example has about 10 adapters (Dropbox, s3 e.t.c)

  • Code clean up ---> The original author wrote this version in the days of 5.3 (pre PSR), The community has agreed on PSR2 but some part of the lib don't conform hence leading to multiple coding standards... While I have spent quite some time fixing those, all isn't done since I wouldn't like to move code around just for PSR conformation without fixing something in there.
    Another thing some part of the codebase uses snake case, others camelCase

  • Many more

@adelowo adelowo self-assigned this Jul 15, 2017
@adelowo adelowo mentioned this issue Aug 5, 2017
@adelowo adelowo closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant