Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe app: kanban board creation #8

Open
GedeonTS opened this issue Aug 29, 2022 · 2 comments
Open

Recipe app: kanban board creation #8

GedeonTS opened this issue Aug 29, 2022 · 2 comments

Comments

@GedeonTS
Copy link
Owner

GedeonTS commented Aug 29, 2022

On this project, our team has two members, who are:

Here is the link to the Kanban.

@sja-thedude
Copy link

sja-thedude commented Aug 29, 2022

Required Changes ♻️

Hi @GedeonTS & @collinsmezie, This is @sja-thedude your code reviewer.

Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!

768070f3-bc9a-4aba-b8bc-25793e00ea1e_text

Required

  • Kindly make sure to add one more column In Review after In Progress to the kanban board.
  • Kindly make sure that you have 2 different cards for:
    1 - Make sure there are no N+1 queries happening.
    2 - Create a navigation menu that allows users to open all of the pages you created.
  • Also make sure to remove these two from the General shopping list view description.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@DammyShittu
Copy link

Hi @GedeonTS @collinsmezie,

APPROVED 🟢

Highlights

✔️ Descriptive PR

Great implementation of all the requirements in this milestone. 👏

You have done an amazing job 👍

Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants