Shy warning dialog window - trying to commit

[tukanos]

Hi @ericwinger ,

I tried to commit, on purpose, to a project that has different sha loaded than on the disk. The dialog window is sometimes quite shy and tries to hide from you.

Here is a screencast (the first time it works, but not the second time):

git_commit_warning_message.mp4

[ericwinger]

There doesn't appear to be anything wrong with raising the dialog itself in JadeiteProjectsTrait>>#mismatchedShasConfirmation. However, if there was more than one morphic process going at the time, I could see how it might get shy as so many things go wrong when multiple morphic processes are running.

Having stated that, I did find JadeiteProjectsTrait>>#gitCommit had some problems with raising the actual commit dialog afterwards which included spawning another morphic process. I fixed those problems by reworking the commit dialog so it could be opened non-modally. Besides that fix, there have been many improvements since this bug was filed that could have left a morphic process lying around at the time of the report.

[tukanos]

Hi @ericwinger ,

thank you for fixing it. I have been migrating Magritte to GS so I wasn't able to test the fixes, but I hope to do it soon.