Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error displayed #991

Open
FedeGueli opened this issue Jul 31, 2023 · 7 comments
Open

Error displayed #991

FedeGueli opened this issue Jul 31, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@chaoran-chen chaoran-chen added the bug Something isn't working label Jul 31, 2023
@chaoran-chen
Copy link
Member

Thanks for reporting this, @FedeGueli! The error message is unfortunately not very precise: The problem is that ORF1a:7162T is wrong (7162 is too large) and we should return a proper error message.

@FedeGueli
Copy link
Author

Thanks for reporting this, @FedeGueli! The error message is unfortunately not very precise: The problem is that ORF1a:7162T is wrong (7162 is too large) and we should return a proper error message.

aahha sorry my bad!!

@fengelniederhammer
Copy link
Contributor

Should we keep this bug to check what the error message looks like in LAPIS 2? And improve there, if necessary?

@chaoran-chen
Copy link
Member

yes, that sounds like a good idea! (Once we launched LAPIS 2, we should go through all open issues and see which have been solved and which are good suggestions that we want to add.)

@JonasKellerer
Copy link
Contributor

I now tested it with lapis2. It now longer shows an error, but the corresponding request ( https://lapis.cov-spectrum.org/gisaid/v2/sample/nucleotideMutations?dateFrom=2023-03-27&dateTo=2023-04-02&aminoAcidMutations=orf1a%3AC7162T&nextcladePangoLineage=XBB.2.3.2*&host=Human&minProportion=0.001&accessKey= ) returns a 400 (with inserted accessKey).

@chaoran-chen Is this what we wanted? The returned error message seems to be right.

grafik

@chaoran-chen
Copy link
Member

LAPIS is doing great but the issue is the cov-spectrum website. Now, it just shows the spinner if we open the link that Fede posted above:

image

Instead, it should properly show the error message on the website.

@chaoran-chen chaoran-chen modified the milestone: COVID-LAPIS May 29, 2024
@chaoran-chen chaoran-chen transferred this issue from GenSpectrum/LAPIS May 29, 2024
@chaoran-chen
Copy link
Member

I moved it to the website repository now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants