Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edges connecting to nodes below and left from a node intersect the nodes #13

Closed
leissler opened this issue Apr 11, 2023 · 2 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@leissler
Copy link
Contributor

leissler commented Apr 11, 2023

When connecting nodes and starting another row in a layout as shown below should somehow be drawn around nodes without intersecting the node space.
image

Examples of proper behavior and rendering are:
image
splines

@Doppelkeks Doppelkeks added enhancement New feature or request help wanted Extra attention is needed labels Apr 17, 2023
@Doppelkeks
Copy link
Contributor

Won't be able to work on a more sophisticated edge draw solution any time soon, so if someone wants to take a shot at this you are welcome to do so :)

Edge drawing is done by https://github.com/Gentlymad-Studios/GraphViewBase. So any proposed changes should probably go into this repository.

The class of interest here is https://github.com/Gentlymad-Studios/GraphViewBase/blob/main/Editor/Elements/Graph/Edge.cs
As this is what handles the visualization of edges using the Painter2D class (https://docs.unity3d.com/2022.2/Documentation/ScriptReference/UIElements.Painter2D.html)

@leissler
Copy link
Contributor Author

leissler commented Jan 4, 2024

I guess this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants