New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing `</script>` closing tag in the doc #4

Open

ThomasG77 opened this issue Aug 21, 2022 · 0 comments

ThomasG77 commented Aug 21, 2022 •

edited

Loading

It seems it's at gitbook.io level doc not in the repo.

In https://xunli.gitbook.io/jsgeoda/user-guide/hello-jsgeoda#pure-js, you provides the following

<html>
<head>
</head>
<body>
<script type="module">
import jsgeoda from 'https://cdn.skypack.dev/-/[email protected]/dist=es2020,mode=imports/optimized/jsgeoda.js';
jsgeoda.New().then((geoda)=> {
    console.log('Hello jsgeoda', geoda.version);
});
</body>
</html>

whereas it should be

<html>
<head>
</head>
<body>
<script type="module">
import jsgeoda from 'https://cdn.skypack.dev/-/[email protected]/dist=es2020,mode=imports/optimized/jsgeoda.js';
jsgeoda.New().then((geoda)=> {
    console.log('Hello jsgeoda', geoda.version);
});
</script>
</body>
</html>

Been aware of the issue as Chrome was working with this unclosed tag whereas Firefox was not auto-fixing the unbalance tag and failing

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment