Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change name in Models.py #82

Open
tienc opened this issue Jul 15, 2019 · 0 comments
Open

change name in Models.py #82

tienc opened this issue Jul 15, 2019 · 0 comments

Comments

@tienc
Copy link

tienc commented Jul 15, 2019

In line 183 of Models.py in the model "DestSum" it prints as:
return self.aggregated_results

All the other models are:
return self.model_results

Could you please make that consistent with the rest of the models?

Thanks!
ifarah added a commit that referenced this issue Jul 30, 2019
@ifarah
Updated notebooks and tweak code
9b43c57 
1. Created new folders (sources, destinations, output_data, matrices, models)
2. Replaced notebooks
3. Added figures
3. Changed code (solving issues)
	- #82: Change syntax to: return self.model_results (Models.py)
	- #84: Do’t return results when calculating the models (Models.py) - I commented it out.
	- #85: focus_categories instead of all_categories (lines 161 and 163 of Models.py)
	- #87: changed plot_type to plot_column (BaseModels.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tienc