Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add predefined regions from python's regionmask #5

Open
3 tasks
briochemc opened this issue Aug 12, 2021 · 11 comments
Open
3 tasks

Comments

@briochemc
Copy link

I mentioned this on Slack a little while ago, but I thought I'd open an issue for your record, in case you have time to look into it.

It would be great to add the regions that python's regionmask currently offers on top of scientific regions:

I'm also pinging @asinghvi17 since I stumbled upon his related (but empty!) NaturalEarth.jl repository, since all of the regions listed above seem to come from naturalearthdata.com!

@natgeo-wong
Copy link
Collaborator

Hi @briochemc, do you have the shapefiles, or some form of raw data that I can have a look at to see how best to extract and put into the package? I definitely would be interested in putting all the regions above into GeoRegions.jl

@briochemc
Copy link
Author

No but they are downloaded automatically via cartopy in the python regionmask tool, so I think you can probably translate ideas from https://github.com/regionmask/regionmask/blob/stable/regionmask/defined_regions/natural_earth.py, no?

@natgeo-wong
Copy link
Collaborator

That probably means that I'll need to download the files directly from natural earth and explore them. I can do that.

Alternatively, I could have a look and see if there is output from regionmask in the lon/lat form and then export it to a textfile or something. But thanks or bringing this up - need some documentation of what to do.

@natgeo-wong
Copy link
Collaborator

I would also add that a global landmask isn't really possible with the functionality of GeoRegions since this would require the combination of multiple GeoRegions that are not otherwise spatially connected.

What would be more appropriate for a landmask would be do download a land-sea mask and apply a filter based on land-sea mask values onto the data.

@briochemc
Copy link
Author

briochemc commented Aug 12, 2021

Yep, I had to do some manual stitching for OceanBasins myself :)

An ideal solution would be to have polygon/region shapes defined on the sphere but I don't know where to look for that directly 🤷 . Meshes.jl maybe?

@natgeo-wong
Copy link
Collaborator

@briochemc if you are interested I might getting around to tackle adding the shapefiles from OceanBasins.jl to GeoRegions.jl myself

@briochemc
Copy link
Author

Yes, please do!

@briochemc
Copy link
Author

Did you end up doing this in the end?

@natgeo-wong
Copy link
Collaborator

Oops not yet, I'm kinda swamped with other things and rewriting GeoRegions.jl (again). Many apologies. I'll get to it.

@asinghvi17
Copy link
Contributor

You can probably just get the regions from NaturalEarth.jl if you're ok with downloading on the fly!

@briochemc
Copy link
Author

No need to apologize! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants