Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve extendibility of class #8

Open
petski opened this issue May 13, 2024 · 0 comments
Open

Improve extendibility of class #8

petski opened this issue May 13, 2024 · 0 comments

Comments

@petski
Copy link

petski commented May 13, 2024

Please update the privates to protecteds to I can extend them in a class deriving from yours.

I.e.

- private function request($method, array $post, $successCallback, $errorCallback)
+ protected function request($method, array $post, $successCallback, $errorCallback)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petski