Skip to content

Commit 39c7743

Browse files
committedSep 25, 2022
src/CMakeLists.txt: Need to set RP_LIBROMDATA_IS_DLL in the current *and* parent scope.
Otherwise, it shows up properly in the build summary, but libromdata always ends up being built as a static library.
1 parent d869f38 commit 39c7743

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed
 

‎debian/changelog

+9
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
rom-properties (2.0-1ppa1~xenial6) xenial; urgency=medium
2+
3+
* Need to set RP_LIBROMDATA_IS_DLL in the current *and* parent scope.
4+
5+
Otherwise, it shows up properly in the build summary, but libromdata
6+
always ends up being built as a static library.
7+
8+
-- David Korth <gerbilsoft@gerbilsoft.com> Sat, 24 Sep 2022 20:02:02 -0400
9+
110
rom-properties (2.0-1ppa1~xenial5) xenial; urgency=medium
211

312
* Re-add #include "dll-macros.h" to KeyStoreUI.hpp and RomFields.hpp.

‎src/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ IF(CMAKE_C_COMPILER MATCHES afl)
9898
# afl-fuzz crashes when trying to load libromdata.so for some reason.
9999
MESSAGE(WARNING "Disabling libromdata.so due to afl")
100100
ELSEIF(WIN32 OR (UNIX AND NOT APPLE))
101+
SET(RP_LIBROMDATA_IS_DLL 1)
101102
SET(RP_LIBROMDATA_IS_DLL 1 PARENT_SCOPE)
102103
ADD_DEFINITIONS(-DRP_LIBROMDATA_IS_DLL=1)
103104
ELSE()

0 commit comments

Comments
 (0)
Please sign in to comment.