Handle missing resource when dropping a datastore (#4343)

GetDKAN · Nov 20, 2024 · 61e73f4 · 61e73f4
1 parent bf01f56
commit 61e73f4
Showing 1 changed file with 21 additions and 14 deletions.
diff --git a/modules/datastore/src/DatastoreService.php b/modules/datastore/src/DatastoreService.php
@@ -269,22 +269,29 @@ public function getDataDictionaryFields(?string $identifier = NULL): ?array {
    */
   public function drop(string $identifier, ?string $version = NULL, bool $remove_local_resource = TRUE) {
     if ($storage = $this->getStorage($identifier, $version)) {
-      $resource = $this->resourceLocalizer->get($identifier, $version);
-      // Dispatch the pre-drop event.
-      $this->eventDispatcher->dispatch(
-        new DatastorePreDropEvent($resource),
-        self::EVENT_DATASTORE_PRE_DROP
-      );
+      $resource = NULL;
+      // Check for the resource before sending the pre-drop event.
+      if ($resource = $this->resourceLocalizer->get($identifier, $version)) {
+        // Dispatch the pre-drop event.
+        $this->eventDispatcher->dispatch(
+          new DatastorePreDropEvent($resource),
+          self::EVENT_DATASTORE_PRE_DROP
+        );
+      }
       // Drop.
       $storage->destruct();
-      // Remove the info from the job store.
-      $this->importJobStoreFactory->getInstance()
-        ->remove(md5($resource->getUniqueIdentifier()));
-      // Dispatch the dropped event.
-      $this->eventDispatcher->dispatch(
-        new DatastoreDroppedEvent($resource),
-        self::EVENT_DATASTORE_DROPPED
-      );
+      // Check for the resource before removing the job store or sending the
+      // dropped event.
+      if ($resource) {
+        // Remove the info from the job store.
+        $this->importJobStoreFactory->getInstance()
+          ->remove(md5($resource->getUniqueIdentifier()));
+        // Dispatch the dropped event.
+        $this->eventDispatcher->dispatch(
+          new DatastoreDroppedEvent($resource),
+          self::EVENT_DATASTORE_DROPPED
+        );
+      }
     }
 
     if ($remove_local_resource) {