From 737b20e4d0bc3b91f9f346d09aa7faaee80839ba Mon Sep 17 00:00:00 2001 From: Santhosh Vaiyapuri <3846977+santhoshvai@users.noreply.github.com> Date: Thu, 10 Oct 2024 11:47:16 +0200 Subject: [PATCH] fix: reject promise if peer connection observer is not found (#2) * fix: promise reject if peer connection observer is not found * 118.1.2-alpha.1 * fix final values * 118.1.2-alpha.2 --- android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java | 4 ++-- package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java index f65550a76..58e4941c6 100644 --- a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java +++ b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java @@ -966,7 +966,7 @@ public void peerConnectionSetConfiguration(ReadableMap configuration, int id) { public void peerConnectionCreateOffer(int id, ReadableMap options, Promise promise) { ThreadUtils.runOnExecutor(() -> { PeerConnectionObserver pco = mPeerConnectionObservers.get(id); - PeerConnection peerConnection = pco.getPeerConnection(); + PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection(); if (peerConnection == null) { Log.d(TAG, "peerConnectionCreateOffer() peerConnection is null"); @@ -1128,7 +1128,7 @@ public void onSetFailure(String s) { public void peerConnectionSetRemoteDescription(int id, ReadableMap desc, Promise promise) { ThreadUtils.runOnExecutor(() -> { PeerConnectionObserver pco = mPeerConnectionObservers.get(id); - PeerConnection peerConnection = pco.getPeerConnection(); + PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection(); if (peerConnection == null) { Log.d(TAG, "peerConnectionSetRemoteDescription() peerConnection is null"); diff --git a/package-lock.json b/package-lock.json index 95092ca30..0d8fde3dc 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@stream-io/react-native-webrtc", - "version": "118.1.1", + "version": "118.1.2-alpha.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@stream-io/react-native-webrtc", - "version": "118.1.1", + "version": "118.1.2-alpha.2", "license": "MIT", "dependencies": { "base64-js": "1.5.1", diff --git a/package.json b/package.json index a3991d1ee..9ffe63561 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@stream-io/react-native-webrtc", - "version": "118.1.1", + "version": "118.1.2-alpha.2", "repository": { "type": "git", "url": "git+https://github.com/GetStream/react-native-webrtc.git"