-
Notifications
You must be signed in to change notification settings - Fork 302
Increase code coverage of compose module #5932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase code coverage of compose module #5932
Conversation
SDK Size Comparison 📏
|
9e65d1e
to
d5da2bd
Compare
a5cf3e8
to
cd6c9b7
Compare
.../src/main/java/io/getstream/chat/android/compose/ui/attachments/content/FileUploadContent.kt
Show resolved
Hide resolved
...o/getstream/chat/android/compose/ui/components/suggestions/mentions/MentionSuggestionList.kt
Outdated
Show resolved
Hide resolved
...android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatPreviewTheme.kt
Show resolved
Hide resolved
...-compose/src/test/kotlin/io/getstream/chat/android/compose/ui/messages/MessagesScreenTest.kt
Show resolved
Hide resolved
...n/src/main/kotlin/io/getstream/chat/android/ui/common/state/pinned/PinnedMessageListState.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor comments
...oid-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatComponentFactory.kt
Outdated
Show resolved
Hide resolved
...main/java/io/getstream/chat/android/compose/viewmodel/channel/ChannelAttachmentsViewModel.kt
Outdated
Show resolved
Hide resolved
...chat/android/compose/ui/messages/composer/internal/DefaultMessageComposerRecordingContent.kt
Show resolved
Hide resolved
stream-chat-android-core/src/testFixtures/kotlin/io/getstream/chat/android/Mother.kt
Outdated
Show resolved
Hide resolved
stream-chat-android-core/src/main/java/io/getstream/chat/android/models/ConnectionState.kt
Show resolved
Hide resolved
2393a1a
to
09e7d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
🎯 Goal
Increase coverage of the COMPOSE module.
Note
Coverage of other modules can be improved on another task.
🛠 Implementation details
coverage.gradle
file to filter out untestable modules and provide accurate source files to SonarQube.Extra tasks
FileUploadItem
.MessageComposerCommandSuggestionListHeader
component factory.AudioWaveVSeekbar