Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for "Unable to set audio speed after pausing" #5451

Conversation

VIPlearner
Copy link
Contributor

@VIPlearner VIPlearner commented Oct 20, 2024

🎯 Goal

fix issue causing users to not be able to set speed after pausing audio #5450

🛠 Implementation details

allow setting speed when audio is paused

🎨 UI Changes

Before After
Screen.Recording.2024-10-20.at.12.52.58.mov
Screen.Recording.2024-10-20.at.12.49.36.mov

🧪 Testing

  • Play audio recording
  • pause audio recording
  • Set speed

🎉 GIF

@VIPlearner VIPlearner requested a review from a team as a code owner October 20, 2024 11:57
@VIPlearner VIPlearner changed the title bug fix for bug fix for "Unable to set audio speed after pausing" Oct 20, 2024
@JcMinarro JcMinarro enabled auto-merge (squash) October 22, 2024 10:17
@JcMinarro
Copy link
Member

@VIPlearner could you check test on this PR?

@VIPlearner
Copy link
Contributor Author

@VIPlearner could you check test on this PR?

Looking into it now
Apologies for late reply

@VIPlearner
Copy link
Contributor Author

Please @JcMinarro I'm trying to check the logs
None of the tests failed I've run it locally as well
The tests don't fail I'm not sure I understand what is causing the failure
The error message says "the operation was cancelled"

Can you please help check
Or maybe help rerun the tests

Unable to set audio speed after pausing
Unable to set audio speed after pausing
@JcMinarro JcMinarro force-pushed the fix/Unable-to-set-audio-speed-after-pausing branch from cf2058f to f083f95 Compare November 12, 2024 15:51
@JcMinarro JcMinarro merged commit 023a997 into GetStream:develop Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants