-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AND-15] Moderation V2 #5493
Merged
Merged
[AND-15] Moderation V2 #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB Entities have been updated. Do we need to upgrade DB Version?
|
JcMinarro
approved these changes
Dec 5, 2024
testableapple
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently discussing issues in slack.
testableapple
approved these changes
Dec 12, 2024
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Add handling for the new
moderation
property of theMessage
object - in addition to the currentmoderationDetails
.Linear: https://linear.app/stream/issue/AND-15/moderation-v2
🛠 Implementation details
DownstreamModerationDto
and include it in theDownstreamMessageDto
(+ corresponding domain models and DB entities)Message.isModerationBounce()
method to also check ifmessage.moderation.action == ModerationAction.bounce
Message.isModerationFlag()
method to also check ifmessage.moderation.action == ModerationAction.flag
(not used at the moment)action == remove
, it is handled automatically via amerror
message🎨 UI Changes
bounce_before.mp4
bounce_after.mp4