-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset channel list in calls to ChannelService.init()? #429
Comments
Hi! Your points make sense to me:
I've added this to the backlog, you'll be notified through this GH issue when this is resolved. |
Hello, do we have any news about this issue? 😁 |
I will try to get this done by the end of August, but I might not be able to do so. |
An update on this: unfortunately, this won't be part of our August release, no ETA for now. As a workaround, you can do this when you want to change the filters:
This doesn't solve the problem completely, as the active channel will change like this: |
Hello!
We have a weird issue that seems to relate to the various calls of
init()
andreset()
on theChannelService
.In short, we have a configuration service that is responsible for setting the standard "filter list" that gets passed to
init()
. We callreset()
and theninit()
. The issue is that sometimes due to a configuration change on the user, the filters will update. If we are on a user's chat page, it will always deselect the active chat, which can cause chats to simply disappear.IMO, it would be a better overall DX if the channel listing was always reset when calling
init()
. As it stands, you either must always callreset()
, which will deselect the chat, even if you don't want it to, or you will get duplicate records in thechannels$
observable.The text was updated successfully, but these errors were encountered: