Skip to content

Commit 4c1d1c3

Browse files
authored
fix: check the presence of remindMe and saveForLater message actions correctly (#2808)
1 parent fc04d13 commit 4c1d1c3

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

src/components/Message/__tests__/utils.test.js

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,20 @@ describe('Message utils', () => {
109109
);
110110
});
111111

112+
it('should return message actions specified in custom actions array depending on channel config if actions are set to true', () => {
113+
const result = getMessageActions(['remindMe'], defaultCapabilities, {
114+
user_message_reminders: true,
115+
});
116+
expect(result).toStrictEqual(['remindMe']);
117+
});
118+
119+
it('should return message actions specified in custom actions array depending on channel config if actions are set to true', () => {
120+
const result = getMessageActions(['saveForLater'], defaultCapabilities, {
121+
user_message_reminders: true,
122+
});
123+
expect(result).toStrictEqual(['saveForLater']);
124+
});
125+
112126
it('should include reminder actions if enabled in channel config', () => {
113127
const result = getMessageActions(true, defaultCapabilities, {
114128
user_message_reminders: true,
@@ -137,9 +151,9 @@ describe('Message utils', () => {
137151
};
138152
const result = getMessageActions(actions, capabilities);
139153
if (capabilityValue) {
140-
expect(result).toContain(action);
154+
expect(result).toStrictEqual([action]);
141155
} else {
142-
expect(result).not.toContain(action);
156+
expect(result).not.toStrictEqual([action]);
143157
}
144158
});
145159
});

src/components/Message/utils.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ export const getMessageActions = (
202202

203203
if (
204204
channelConfig?.['user_message_reminders'] &&
205-
messageActions.indexOf(MESSAGE_ACTIONS.remindMe)
205+
messageActions.indexOf(MESSAGE_ACTIONS.remindMe) > -1
206206
) {
207207
messageActionsAfterPermission.push(MESSAGE_ACTIONS.remindMe);
208208
}
@@ -213,7 +213,7 @@ export const getMessageActions = (
213213

214214
if (
215215
channelConfig?.['user_message_reminders'] &&
216-
messageActions.indexOf(MESSAGE_ACTIONS.saveForLater)
216+
messageActions.indexOf(MESSAGE_ACTIONS.saveForLater) > -1
217217
) {
218218
messageActionsAfterPermission.push(MESSAGE_ACTIONS.saveForLater);
219219
}

0 commit comments

Comments
 (0)