Make cron checks work on v5 (#3875)

testableapple · web-flow · commit ab527b303489 · 2025-11-13T10:24:25.000Z
diff --git a/.github/workflows/cron-checks.yml b/.github/workflows/cron-checks.yml
@@ -22,23 +22,19 @@ jobs:
       matrix:
         include:
           - ios: 18.5
-            xcode: 16.4
             os: macos-15
             device: "iPhone 16 Pro"
             setup_runtime: false
           - ios: 17.5
-            xcode: 15.4
-            os: macos-14
+            os: macos-15
             device: "iPhone 15 Pro"
-            setup_runtime: false
+            setup_runtime: true
           - ios: 16.4
-            xcode: 15.3 # fails on 15.4
-            os: macos-14
+            os: macos-15
             device: "iPhone 14 Pro"
             setup_runtime: true
           - ios: 15.5
-            xcode: 15.3 # fails on 15.4
-            os: macos-14
+            os: macos-15
             device: "iPhone 13 Pro"
             setup_runtime: true
       fail-fast: false
@@ -47,7 +43,7 @@ jobs:
       GITHUB_EVENT: ${{ toJson(github.event) }}
       ALLURE_TOKEN: ${{ secrets.ALLURE_TOKEN }}
       STREAM_DEMO_APP_SECRET: ${{ secrets.STREAM_DEMO_APP_SECRET }}
-      XCODE_VERSION: ${{ matrix.xcode }}
+      XCODE_VERSION: "26.0.1"
       IOS_SIMULATOR_DEVICE: "${{ matrix.device }} (${{ matrix.ios }})" # For the Allure report
     steps:
     - uses: actions/checkout@v4.1.1
@@ -66,7 +62,7 @@ jobs:
     - name: Launch Allure TestOps
       run: bundle exec fastlane allure_launch cron:true
     - name: Run UI Tests (Debug)
-      run: bundle exec fastlane test_e2e_mock device:"${{ matrix.device }} (${{ matrix.ios }})"
+      run: bundle exec fastlane test_e2e_mock device:"${{ env.IOS_SIMULATOR_DEVICE }}"
       timeout-minutes: 120
     - name: Allure TestOps Upload
       if: success() || failure()
@@ -95,29 +91,26 @@ jobs:
       matrix:
         include:
           - ios: 18.5
-            xcode: 16.4
             os: macos-15
             device: "iPhone 16 Pro"
             setup_runtime: false
           - ios: 17.5
             xcode: 15.4
-            os: macos-14
+            os: macos-15
             device: "iPhone 15 Pro"
-            setup_runtime: false
+            setup_runtime: true
           - ios: 16.4
-            xcode: 15.3 # fails on 15.4
-            os: macos-14
+            os: macos-15
             device: "iPhone 14 Pro"
             setup_runtime: true
           - ios: 15.5
-            xcode: 15.3 # fails on 15.4
-            os: macos-14
+            os: macos-15
             device: "iPhone 13 Pro"
             setup_runtime: true
       fail-fast: false
     runs-on: ${{ matrix.os }}
     env:
-      XCODE_VERSION: ${{ matrix.xcode }}
+      XCODE_VERSION: "26.0.1"
     steps:
     - uses: actions/checkout@v4.1.1
     - uses: ./.github/actions/bootstrap
@@ -147,10 +140,10 @@ jobs:
           fastlane/test_output/logs/*/Diagnostics/simctl_diagnostics/DiagnosticReports/*
 
   build-old-xcode:
-    name: Build LLC + UI (Xcode 15)
+    name: Build SDKs (Old Xcode)
     runs-on: macos-14
     env:
-      XCODE_VERSION: "15.4"
+      XCODE_VERSION: "16.1"
     steps:
     - name: Connect Bot
       uses: webfactory/ssh-agent@v0.7.0
diff --git a/.github/workflows/smoke-checks.yml b/.github/workflows/smoke-checks.yml
@@ -61,22 +61,21 @@ jobs:
       - run: bundle exec fastlane validate_public_interface
 
   build-old-xcode:
-    name: Build LLC + UI (Xcode 15)
-    runs-on: macos-15
-    # if: ${{ github.event.inputs.record_snapshots != 'true' }}
-    if: false # disable Xcode 15 builds
+    name: Build SDKs (Old Xcode)
+    runs-on: macos-14
+    if: ${{ github.event.inputs.record_snapshots != 'true' }}
     env:
-      XCODE_VERSION: "15.4"
+      XCODE_VERSION: "16.1"
     steps:
     - uses: actions/checkout@v4.1.1
     - uses: ./.github/actions/ruby-cache
     - name: List Xcode versions
       run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'"
     - name: Build LLC
-      run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true
+      run: bundle exec fastlane test device:"iPhone 16 (18.1)" build_for_testing:true
       timeout-minutes: 25
     - name: Build UI
-      run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true
+      run: bundle exec fastlane test_ui device:"iPhone 16 (18.1)" build_for_testing:true
       timeout-minutes: 25
 
   test-llc-debug:
diff --git a/DemoApp/Screens/UserProfile/UserProfileViewController.swift b/DemoApp/Screens/UserProfile/UserProfileViewController.swift
@@ -298,11 +298,13 @@ class UserProfileViewController: UITableViewController, CurrentChatUserControlle
         loadingSpinner.startAnimating()
         
         uploadImageAndUpdateProfile(selectedImage) { [weak self] error in
-            self?.loadingSpinner.stopAnimating()
-            if let error = error {
-                self?.showError(error)
-            } else {
-                self?.showSuccess()
+            Task { @MainActor [weak self] in
+                self?.loadingSpinner.stopAnimating()
+                if let error = error {
+                    self?.showError(error)
+                } else {
+                    self?.showSuccess()
+                }
             }
         }
     }
diff --git a/Sources/StreamChat/Repositories/ConnectionRepository.swift b/Sources/StreamChat/Repositories/ConnectionRepository.swift
@@ -177,6 +177,9 @@ class ConnectionRepository: @unchecked Sendable {
              .authenticating:
             shouldNotifyConnectionIdWaiters = false
             connectionId = nil
+        @unknown default:
+            shouldNotifyConnectionIdWaiters = false
+            connectionId = nil
         }
 
         updateConnectionId(
diff --git a/Sources/StreamChat/WebSocketClient/Events/MessageEvents.swift b/Sources/StreamChat/WebSocketClient/Events/MessageEvents.swift
@@ -5,7 +5,7 @@
 import Foundation
 
 /// Triggered when a new message is sent to channel.
-final public class MessageNewEvent: ChannelSpecificEvent, HasUnreadCount {
+public final class MessageNewEvent: ChannelSpecificEvent, HasUnreadCount {
     /// The user who sent a message.
     public let user: ChatUser
 
@@ -332,19 +332,19 @@ public final class NewMessageErrorEvent: ChannelSpecificEvent {
 public final class MessageDeliveredEvent: ChannelSpecificEvent {
     /// The user who received the delivered message.
     public let user: ChatUser
-    
+
     /// The channel identifier the message was delivered to.
     public var cid: ChannelId { channel.cid }
-    
+
     /// The channel the message was delivered to.
     public let channel: ChatChannel
-    
+
     /// The event timestamp.
     public let createdAt: Date
-    
+
     /// The ID of the last delivered message.
     public let lastDeliveredMessageId: MessageId
-    
+
     /// The timestamp when the message was delivered.
     public let lastDeliveredAt: Date
 
diff --git a/Sources/StreamChatUI/ChatChannelList/ChatChannelListVC.swift b/Sources/StreamChatUI/ChatChannelList/ChatChannelListVC.swift
@@ -441,6 +441,8 @@ open class ChatChannelListVC: _ViewController,
                 shouldHideEmptyView = emptyView.isHidden
                 isLoading = false
                 channelListErrorView.show()
+            @unknown default:
+                break
             }
 
             emptyView.isHidden = shouldHideEmptyView
diff --git a/Sources/StreamChatUI/ChatMessageList/Attachments/File/ChatFileAttachmentListView+ItemView.swift b/Sources/StreamChatUI/ChatMessageList/Attachments/File/ChatFileAttachmentListView+ItemView.swift
@@ -123,6 +123,8 @@ extension ChatMessageFileAttachmentListView {
                     fileSizeLabel.text = content?.downloadingState?.fileProgress
                 case .downloaded, .downloadingFailed:
                     fileSizeLabel.text = content?.payload.file.sizeString
+                @unknown default:
+                    break
                 }
             } else if let uploadState {
                 switch uploadState {
@@ -132,6 +134,8 @@ extension ChatMessageFileAttachmentListView {
                     fileSizeLabel.text = L10n.Message.Sending.attachmentUploadingFailed
                 case .pendingUpload, .uploaded, .unknown:
                     fileSizeLabel.text = content?.payload.file.sizeString
+                @unknown default:
+                    break
                 }
             } else {
                 fileSizeLabel.text = content?.payload.file.sizeString
diff --git a/Sources/StreamChatUI/ChatMessageList/Attachments/UploadingOverlayView.swift b/Sources/StreamChatUI/ChatMessageList/Attachments/UploadingOverlayView.swift
@@ -113,6 +113,8 @@ open class UploadingOverlayView: _View, ThemeProvider {
                 return .restart
             case .uploaded:
                 return .uploaded
+            @unknown default:
+                return nil
             }
         }
         actionButton.isHidden = actionButton.content == nil
@@ -127,6 +129,8 @@ open class UploadingOverlayView: _View, ThemeProvider {
                 return nil
             case .uploadingFailed:
                 return L10n.Message.Sending.attachmentUploadingFailed
+            @unknown default:
+                return nil
             }
         }
         uploadingProgressLabel.isHidden = uploadingProgressLabel.text == nil
@@ -171,6 +175,8 @@ extension LocalAttachmentState {
             return "0/\(file.sizeString)"
         case .uploaded, .uploadingFailed, .unknown:
             return file.sizeString
+        @unknown default:
+            return ""
         }
     }
 }
@@ -190,6 +196,8 @@ extension AttachmentDownloadingState {
             return file?.progressDescription(for: progress) ?? ""
         case .downloaded, .downloadingFailed:
             return file?.sizeString ?? ""
+        @unknown default:
+            return ""
         }
     }
 }
@@ -203,6 +211,8 @@ extension AttachmentUploadingState {
             return "0 / \(file.sizeString)"
         case .uploaded, .uploadingFailed, .unknown:
             return file.sizeString
+        @unknown default:
+            return ""
         }
     }
 }
diff --git a/Sources/StreamChatUI/ChatMessageList/Reactions/ChatMessageReactionsPickerVC.swift b/Sources/StreamChatUI/ChatMessageList/Reactions/ChatMessageReactionsPickerVC.swift
@@ -84,6 +84,7 @@ open class ChatMessageReactionsPickerVC: _ViewController, ThemeProvider, ChatMes
         switch change {
         case .create, .remove: break
         case .update: updateContentIfNeeded()
+        @unknown default: break
         }
     }
 }
diff --git a/Sources/StreamChatUI/ChatThread/ChatThreadVC.swift b/Sources/StreamChatUI/ChatThread/ChatThreadVC.swift
@@ -451,6 +451,8 @@ open class ChatThreadVC: _ViewController,
             listChange = .update(item, index: indexPath)
         case let .remove(item):
             listChange = .remove(item, index: indexPath)
+        @unknown default:
+            return
         }
 
         updateMessages(with: [listChange])
diff --git a/Sources/StreamChatUI/ChatThreadList/ChatThreadListVC.swift b/Sources/StreamChatUI/ChatThreadList/ChatThreadListVC.swift
@@ -317,6 +317,8 @@ open class ChatThreadListVC:
             showErrorView()
         case .localDataFetchFailed:
             break
+        @unknown default:
+            break
         }
     }
 
diff --git a/Sources/StreamChatUI/MessageActionsPopup/ChatMessageActionsVC.swift b/Sources/StreamChatUI/MessageActionsPopup/ChatMessageActionsVC.swift
@@ -185,6 +185,8 @@ open class ChatMessageActionsVC: _ViewController, ThemeProvider {
                 editActionItem(),
                 deleteActionItem()
             ]
+        @unknown default:
+            return []
         }
     }
 
diff --git a/Sources/StreamChatUI/StreamDifferenceKit/Algorithm.swift b/Sources/StreamChatUI/StreamDifferenceKit/Algorithm.swift
@@ -486,6 +486,9 @@ internal func diff<E: Differentiable, I>(
 
             case .duplicate(let reference)?:
                 reference.push(sourceIndex)
+                
+            @unknown default:
+                break
             }
         }
 
@@ -509,6 +512,9 @@ internal func diff<E: Differentiable, I>(
                     targetReferences[targetIndex] = sourceIndex
                     sourceTraces[sourceIndex].reference = targetIndex
                 }
+                
+            @unknown default:
+                break
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -298,11 +298,13 @@ class UserProfileViewController: UITableViewController, CurrentChatUserControlle`
`298`	`298`	`loadingSpinner.startAnimating()`
`299`	`299`
`300`	`300`	`uploadImageAndUpdateProfile(selectedImage) { [weak self] error in`
`301`		`- self?.loadingSpinner.stopAnimating()`
`302`		`- if let error = error {`
`303`		`- self?.showError(error)`
`304`		`- } else {`
`305`		`- self?.showSuccess()`
	`301`	`+ Task { @MainActor [weak self] in`
	`302`	`+ self?.loadingSpinner.stopAnimating()`
	`303`	`+ if let error = error {`
	`304`	`+ self?.showError(error)`
	`305`	`+ } else {`
	`306`	`+ self?.showSuccess()`
	`307`	`+ }`
`306`	`308`	`}`
`307`	`309`	`}`
`308`	`310`	`}`
Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,9 @@ class ConnectionRepository: @unchecked Sendable {`
`177`	`177`	`.authenticating:`
`178`	`178`	`shouldNotifyConnectionIdWaiters = false`
`179`	`179`	`connectionId = nil`
	`180`	`+ @unknown default:`
	`181`	`+ shouldNotifyConnectionIdWaiters = false`
	`182`	`+ connectionId = nil`
`180`	`183`	`}`
`181`	`184`
`182`	`185`	`updateConnectionId(`
Original file line number	Diff line number	Diff line change
`@@ -441,6 +441,8 @@ open class ChatChannelListVC: _ViewController,`
`441`	`441`	`shouldHideEmptyView = emptyView.isHidden`
`442`	`442`	`isLoading = false`
`443`	`443`	`channelListErrorView.show()`
	`444`	`+ @unknown default:`
	`445`	`+ break`
`444`	`446`	`}`
`445`	`447`
`446`	`448`	`emptyView.isHidden = shouldHideEmptyView`
Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,8 @@ open class UploadingOverlayView: _View, ThemeProvider {`
`113`	`113`	`return .restart`
`114`	`114`	`case .uploaded:`
`115`	`115`	`return .uploaded`
	`116`	`+ @unknown default:`
	`117`	`+ return nil`
`116`	`118`	`}`
`117`	`119`	`}`
`118`	`120`	`actionButton.isHidden = actionButton.content == nil`
`@@ -127,6 +129,8 @@ open class UploadingOverlayView: _View, ThemeProvider {`
`127`	`129`	`return nil`
`128`	`130`	`case .uploadingFailed:`
`129`	`131`	`return L10n.Message.Sending.attachmentUploadingFailed`
	`132`	`+ @unknown default:`
	`133`	`+ return nil`
`130`	`134`	`}`
`131`	`135`	`}`
`132`	`136`	`uploadingProgressLabel.isHidden = uploadingProgressLabel.text == nil`
`@@ -171,6 +175,8 @@ extension LocalAttachmentState {`
`171`	`175`	`return "0/\(file.sizeString)"`
`172`	`176`	`case .uploaded, .uploadingFailed, .unknown:`
`173`	`177`	`return file.sizeString`
	`178`	`+ @unknown default:`
	`179`	`+ return ""`
`174`	`180`	`}`
`175`	`181`	`}`
`176`	`182`	`}`
`@@ -190,6 +196,8 @@ extension AttachmentDownloadingState {`
`190`	`196`	`return file?.progressDescription(for: progress) ?? ""`
`191`	`197`	`case .downloaded, .downloadingFailed:`
`192`	`198`	`return file?.sizeString ?? ""`
	`199`	`+ @unknown default:`
	`200`	`+ return ""`
`193`	`201`	`}`
`194`	`202`	`}`
`195`	`203`	`}`
`@@ -203,6 +211,8 @@ extension AttachmentUploadingState {`
`203`	`211`	`return "0 / \(file.sizeString)"`
`204`	`212`	`case .uploaded, .uploadingFailed, .unknown:`
`205`	`213`	`return file.sizeString`
	`214`	`+ @unknown default:`
	`215`	`+ return ""`
`206`	`216`	`}`
`207`	`217`	`}`
`208`	`218`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,7 @@ open class ChatMessageReactionsPickerVC: _ViewController, ThemeProvider, ChatMes`
`84`	`84`	`switch change {`
`85`	`85`	`case .create, .remove: break`
`86`	`86`	`case .update: updateContentIfNeeded()`
	`87`	`+ @unknown default: break`
`87`	`88`	`}`
`88`	`89`	`}`
`89`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -451,6 +451,8 @@ open class ChatThreadVC: _ViewController,`
`451`	`451`	`listChange = .update(item, index: indexPath)`
`452`	`452`	`case let .remove(item):`
`453`	`453`	`listChange = .remove(item, index: indexPath)`
	`454`	`+ @unknown default:`
	`455`	`+ return`
`454`	`456`	`}`
`455`	`457`
`456`	`458`	`updateMessages(with: [listChange])`