Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access to the isVoiceRecordingConfirmationRequiredEnabled flag #564

Open
felipeska opened this issue Jul 30, 2024 · 2 comments
Open

access to the isVoiceRecordingConfirmationRequiredEnabled flag #564

felipeska opened this issue Jul 30, 2024 · 2 comments

Comments

@felipeska
Copy link

What are you trying to achieve?

I'm trying to change the next flag:

https://github.com/GetStream/stream-chat-swift/blob/develop/Sources/StreamChatUI/Components.swift#L540

 /// When set to `true` recorded messages can be grouped together and send as part of one message.
 /// When set to `false`, recorded messages will be sent instantly.
 public var isVoiceRecordingConfirmationRequiredEnabled = true

If possible, how can you achieve this currently?

Not sure if I can access to this specific component configuration, in a similar way to the isVoiceRecordingEnabled provided in the ComposerConfig

/// Config for customizing the composer.
public struct ComposerConfig {

    public var isVoiceRecordingEnabled: Bool
   ///....

    public init(
        isVoiceRecordingEnabled: Bool = false,
    ///....

What would be the better way?

would be great having both configurations in the ComposerConfig API

public struct ComposerConfig {

    public var isVoiceRecordingEnabled: Bool
    public var isVoiceRecordingConfirmationRequiredEnabled: Bool
    ///....

    public init(
        isVoiceRecordingEnabled: Bool = false,
        isVoiceRecordingConfirmationRequiredEnabled = true
    ///....

GetStream Environment

GetStream Chat version: 4.60.0
GetStream Chat frameworks: StreamChat, StreamChatSwiftUI
iOS version:
Swift version:
Xcode version:
Device:

Additional context

@martinmitrevski
Copy link
Contributor

Hey @felipeska,

This is not implemented on SwiftUI yet. We will keep it open, since it's in our roadmap, but I can't tell at the moment about any ETA.

Best, Martin

@Vissie2
Copy link

Vissie2 commented Sep 3, 2024

We also would like to see this feature implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants