Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metro commonjs issues with optional libs #1625

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

santhoshvai
Copy link
Member

on commonjs, metro's module resolution has unpredicatable behaviour in a single file,if one of the module is not installed

Solution: move modules that may not be installed into its own file

fixes #1620

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated: added for easy local testing with yarn pack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant