-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WofE CLI functions #475
Draft
msorvoja
wants to merge
7
commits into
master
Choose a base branch
from
333-add-cli-functions-for-wofe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaarnio
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my comments below, please add CLI function for agterberg_cheng_CI_test
tool
…culate_responses_cli
@nmaarnio Ready for another review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CLI functions for the two WofE functions.
In the first CLI function (
weights_of_evidence_calculate_weights_cli
), the resulting dataframe is saved into a CSV file and the arrays are saved as rasters. The number of deposit pixels and evidence pixels are only printed to the user.In the second CLI function (
weights_of_evidence_calculate_responses_cli
), the resulting probability and confidence arrays are saved as rasters.In the latter CLI function, there are at least two options how to transform the input rasters into an array of dictionaries needed in the corresponding toolkit function:
weights_of_evidence_calculate_weights_cli
are in separate folders. As many dictionaries will be created as there are distinct (innermost) folders in the paths of the input rasters. I'm not sure whether this approach will work with the plugin.I believe the first approach makes more sense, but I'll let you comment which approach you prefer @nmaarnio.