Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action template #687

Open
3 tasks
GG-HH opened this issue Aug 11, 2023 · 0 comments
Open
3 tasks

Improve action template #687

GG-HH opened this issue Aug 11, 2023 · 0 comments
Labels
status:confirmed This issue has been reviewed and confirmed type:feature Feature request

Comments

@GG-HH
Copy link
Collaborator

GG-HH commented Aug 11, 2023

Is your feature request related to a problem? Please describe.

Currently, the template for GitHub action requires the definition of external variables. This is a pain to me because my action templates are bigger than what's needed.

Describe the solution you'd like

It would be nice if the action did not require any environment variables definition by default.

Describe alternatives you've considered

Keep the current behavior.

Additional context

All those environment variables are defined from GitHub event payload. This payload should be accessible through the code because GitHub stores a JSON file containing the events (see GITHUB_EVENT_PATH env variable in this documentation)

Definition of Done

  • Our GitHub action code no longer requires our users to define GITHUB_PUSH_BEFORE_SHA, GITHUB_PUSH_BASE_SHA or GITHUB_DEFAULT_BRANCH;
  • For consistency, it would be good to read all variables from the .json file;
  • The action documentation has been updated accordingly. Note: this documentation update must only be published after the changes have been released!
@GG-HH GG-HH added type:feature Feature request status:new This issue needs to be reviewed labels Aug 11, 2023
@agateau-gg agateau-gg added status:confirmed This issue has been reviewed and confirmed and removed status:new This issue needs to be reviewed labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed This issue has been reviewed and confirmed type:feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants