SwiftLint #17
Closed
SwiftLint #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
February 2, 2018 22:54
… lines to come back under 120 length
… the line_length rule (120)
…to come in under line_length 120
…fixes:)` as this usage doesn't seem like a major offender ;p
…xamples/ViewController.swift, as this is clearly a deliberate "violation"
…aSource, UITableViewDelegate, and MessageAutocompleteControllerDelegate, which alleviates the prior line_length violation for `class ViewController: MessageViewController, UITableViewDataSource, UITableViewDelegate, MessageAutocompleteControllerDelegate { /* ... */ }`
…ew+util_adjustedContentInset as this is deliberately done
…n in MessageViewController/MessageView.swift
|
Lovely, this is great! |
Fogh
approved these changes
Mar 14, 2018
|
For this to work I guess we should setup a CI to build the project. The same goes for making |
|
@Fogh coming back around, mind resolving some conflicts really quick? Or maybe split into adding SwiftLint as a PR, then fixing lints? |
|
@rnystrom Sure, I will look into this ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates SwiftLint to lint all the swifts! Closes #16
Questions:
.swiftlint.yml?swiftlint --strict, that work? Or do you prefer it without--strictCode Changes (not just whitespace):
class ViewController: MessageViewController, UITableViewDataSource, UITableViewDelegate, MessageAutocompleteControllerDelegatewas violating the line_length rule, so I switched it toclass ViewController: MessageViewController ... extension ViewController: UITableViewDataSource, etc.. You may prefer a revert, and just disabling that rule there