File tree Expand file tree Collapse file tree 1 file changed +6
-13
lines changed Expand file tree Collapse file tree 1 file changed +6
-13
lines changed Original file line number Diff line number Diff line change @@ -134,21 +134,14 @@ def test_connection():
134134 if not success :
135135 # Log the detailed error server-side
136136 print (f"Sanitized error: { message } " )
137- # Provide generic error for user
137+ # Provide generic error for user, never send message details
138138 user_message = "Connection test failed. Please check your details and try again or contact support."
139- return jsonify ({'success' : False , 'message' : user_message })
140-
141- # Only allow pre-approved success messages to be sent back to the user
142- allowed_success_prefixes = [
143- "Successfully connected" ,
144- "Connected, but domain" ,
145- "Connected, but domain" ,
146- ]
139+ result = {'success' : False , 'message' : user_message }
140+ print (f"Sending response: { result } " )
141+ return jsonify (result )
142+
143+ # Only allow strictly safe success message to be sent back to the user
147144 user_message = "Successfully connected to DirectAdmin."
148- for prefix in allowed_success_prefixes :
149- if message .startswith (prefix ):
150- user_message = message
151- break
152145 result = {
153146 'success' : True ,
154147 'message' : user_message
You can’t perform that action at this time.
0 commit comments