Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal linux mono packages #1229

Closed
bryceschober opened this issue Jun 5, 2017 · 8 comments
Closed

Minimal linux mono packages #1229

bryceschober opened this issue Jun 5, 2017 · 8 comments
Labels

Comments

@bryceschober
Copy link

The docs say mono-complete is required, which installs >170 MB more than mono-runtime on my system (Ubuntu 14.04).

After some fooling around, it seems that mono-mcs is sufficient for at least a trivial execution, and that installs only 6 MB more than mono-runtime.

Could someone verify with a more complete test suite (or some less experimental approach) whether mono-mcs is truly sufficient?

@asbjornu
Copy link
Member

asbjornu commented Jun 8, 2017

@bryceschober: You're free to tweak the .travis.yml configuration file to see how much dependency weight you can shave off. Not sure it's possible, but this shaving should perhaps be reflected in GitVersion's Homebrew Formula as well. If you manage to shave off a few megabytes and the Travis tests are still green, we're happy to accept a pull request. 😃

@bryceschober
Copy link
Author

@asbjornu: I don't see a way any place to specify a minimal mono installation except in the src/DockerBase/Dockerfile. Is the docker image actually used in any of your automated testing?

I'm not sure how I could test a different build environment (which would require a pretty complete mono install) than the test environment...

@asbjornu
Copy link
Member

asbjornu commented Jun 8, 2017

Good point. I supposed neither Homebrew nor Travis allows for that sort of specificity. Could we test the Docker image somehow, though? If we got that set up, we could adjust it to only use the bare minimum dependencies required to execute successfully.

@bryceschober
Copy link
Author

Sorry, I'm just a user-level newbie and have no idea if your test suite could run from the docker image, or if the nature of the test infrastructure is that it would require a full mono install just to run any test.

@JakeGinnivan
Copy link
Contributor

This sounds like a good change to me! I would be happy to change it and see if anyone complains. As long as GitVersion runs the normalisation properly (when on a build server for instance) then I think it's probably fine to say it works.

@asbjornu
Copy link
Member

@JakeGinnivan: Sure, that's a viable approach as well. Let's do it! 😄

@dazinator
Copy link
Member

Once #1269 is done, you should also be able to run on linux under dotnet core if that is something that interests you.

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2019
@stale stale bot closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants