Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop minor version is bumped when merging a feature branch with a major version number #1519

Closed
DOMZE opened this issue Oct 26, 2018 · 8 comments

Comments

@DOMZE
Copy link

DOMZE commented Oct 26, 2018

Hello,

I have a question on GitVersion. In the scenario shown in the diagram below, how come the minor version is bumped when the feature branch is merged back into develop?

I would expect the version in develop to stay the same as there's no release branches associated with 2.0.0 and no tags in develop with 2.0.0

flow

Does the tool automatically update the minor version on the next commit when it is tracking a release branch (regardless of the version)?

For information this is my GitVersion.yml

mode: ContinuousDeployment branches: {} ignore: sha: []

Using GitVersion 4.0.0

Git commands to reproduce the behavior:

git init
gitversion init (selecting, 5,2,0)

git add GitVersion.yml; git commit -m "Initial commit"; git checkout -b develop;
git commit -m "First commit in develop" --allow-empty
git checkout -b release/1.0.0
git commit -m "bugfix in release/1.0.0" --allow-empty
git checkout develop; git checkout -b feature/2.0.0;
git commit -m "first commit in feature/2.0.0" --allow-empty;
git checkout develop
git merge feature/2.0.0 --no-ff

Thank you!

@gep13
Copy link
Member

gep13 commented Oct 29, 2018

@DOMZE I believe the problem here may be down to the usage of the version number in the feature branch. Can you try the above again without using feature/2.0.0. Perhaps using something like feature/add-page or equivalent. That does that result in?

@DOMZE
Copy link
Author

DOMZE commented Oct 29, 2018

@gep13 The idea behind the flow I mentioned was that I was hoping to increase a major version through a feature branch but I understand that one can do that with a commit message (+semver: major)

If this is not the intended behavior, do you think the tool should be fixed accordingly (a.k.a not allow that) as it can result to a really mix up of versioning

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2019
@DOMZE
Copy link
Author

DOMZE commented Jul 28, 2019

Bump

@stale stale bot removed the stale label Jul 28, 2019
@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 26, 2019
@DOMZE
Copy link
Author

DOMZE commented Oct 27, 2019

This has been hanging in for a while. Is this something that may be fixed (ignore versions in feature branch names) or should this issue be closed?

@stale stale bot removed the stale label Oct 27, 2019
@asbjornu
Copy link
Member

Didn't #1541 fix this?

@DOMZE
Copy link
Author

DOMZE commented Nov 3, 2019

ah cool then didn't see that PR :-) thanks!

@DOMZE DOMZE closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants