-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RND-2311: enums for server url in openapi block #2452
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d9ee1a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
be799b1
to
c84cf3d
Compare
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
c84cf3d
to
cde6f2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick first pass, I think we should abstract the concept of enum you are introducing here (enum is also a confusing name btw), to also be used for other client states that the block needs.
packages/gitbook/src/app/(space)/(content)/[[...pathname]]/page.tsx
Outdated
Show resolved
Hide resolved
ec4c412
to
d28d46b
Compare
0d7e4b6
to
2b7ea27
Compare
…tbook into brett/RND-2311-openapi-enum
With this PR, open api schemas with an array of servers and variables for server urls will allow selection of the variables and choice of server.
Updating code samples and scalar modal's server url when updated. Which fixes Issue #2432
CleanShot.2024-09-12.at.17.11.32.mp4