Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do path and file validation to avoid 500 errors #26

Open
qqmyers opened this issue Jun 5, 2024 · 0 comments
Open

Do path and file validation to avoid 500 errors #26

qqmyers opened this issue Jun 5, 2024 · 0 comments

Comments

@qqmyers
Copy link
Member

qqmyers commented Jun 5, 2024

Operating systems allow characters in paths and filenames that Dataverse does not. In gdcc/dvwebloader#27, checks have been added to see if there are invalid chars in either filename or path and to give the user the option to not upload or allow substitution of an underscore for any disallowed chars. That PR also handles path/name munging when checking for files that already exist in the dataset. DVUploader should probably do the same and, after a quick code check, I don't think it does.

The symptom seen with dvwebloader in both cases (filename or directoryLabel) was a 500 error from Dataverse.

Note that with direct uploads, this failure leaves orphaned files in the bucket - cleaning temp files using the temp tag or calling the clean orphan files api in Dataverse will remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant