Wrong units when graphing body weight readings #409
Assignees
Labels
Comments
chwalters
pushed a commit
that referenced
this issue
Apr 25, 2018
…cosio base class for all presenters, to avoid copy/paste/redundant code for detecting units.
Merged
emartynov
pushed a commit
that referenced
this issue
Jun 7, 2018
…cosio base class for all presenters, to avoid copy/paste/redundant code for detecting units.
emartynov
pushed a commit
that referenced
this issue
Jun 7, 2018
* Fixes and refactoring for #407. Pulled up number formatter to activity super class so all reading editors can use it (secondary issue raised by ticket). Modified weight activity to convert from kg to lbs if user preferences require it, to fix primary issue on ticket. * Fixes for #409. My feeling is that we probably should/have/need a Glucosio base class for all presenters, to avoid copy/paste/redundant code for detecting units. * Amended as per @emartynov comments on PR * Amended as per @emartynov comments on PR * Returning test back and fixing it * Small test cleanup - removing unnecessary class and fixing deprecated imports * Update Analytics based on Goggle implementation knowledge * Fixed compilation after renaming (I hoped that tool can handle it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On the overview screen, select body weight. If user settings are for imperial units (lbs) - this is ignored on the chart and values are shown in metric (kg). To reproduce, add body weight readings in imperial units (lbs) and then try to chart them. Desire behaviour is to show the chart using the settings chosen by the user.
The text was updated successfully, but these errors were encountered: