Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opacity.py -- mtpts #5

Open
grahamkerr opened this issue Feb 25, 2020 · 2 comments
Open

opacity.py -- mtpts #5

grahamkerr opened this issue Feb 25, 2020 · 2 comments

Comments

@grahamkerr
Copy link
Contributor

So, I think this is the correct way to bring your attention to something?

In opacity.py, when you are reading opctab.dat using the roptab function, the variable mtpts is hardcoded as 39.

This is the typical value used in opctab.dat but this can actually vary and some older versions of the RADYN version that Joel, Adam, and I used have mtpts = 34.

Would it be possible to have this as a keyword, defaulted to 39, that the user can vary?

@Goobley
Copy link
Owner

Goobley commented Feb 25, 2020

Okay, the original was just based on the version of the IDL code I had. At first glance it would be best to see if we can infer the value from the structure of the file somehow. Does one of the variables let us easily figure this out? Otherwise it should be a kwarg, but I would rather have it as idiot-proof as possible if it's something that can vary.

@grahamkerr
Copy link
Contributor Author

I'll check but I imagine so -- it is the number of temperature points used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants