Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include minified js and css in npm package #138

Closed
jab opened this issue Feb 23, 2017 · 7 comments
Closed

include minified js and css in npm package #138

jab opened this issue Feb 23, 2017 · 7 comments

Comments

@jab
Copy link

jab commented Feb 23, 2017

The dialog-polyfill NPM package does not currently include minified versions of the js and css.

As a result, many NPM users, and therefore users of the unpkg.com CDN, pull in unminified versions of these assets into their pages. Would you consider including minified versions in the NPM package?

Thanks for your consideration and for the great work on dialog-polyfill!

@jab
Copy link
Author

jab commented Feb 23, 2017

@samthor
Copy link
Contributor

samthor commented Feb 23, 2017

It's something I've thought about. I do it for e.g. inert-polyfill, which was created much more recently.

QQ: Inert includes the minified CSS inside the minified JS and adds it to the page as needed. Would that be useful for dialog, or is that actually a pretty weird concept?

@jab
Copy link
Author

jab commented Feb 23, 2017

Including the CSS in the JS sounds great to me, thanks, and glad you're amenable to this!

@mreinstein
Copy link
Contributor

@samthor would you be open to a PR for including minified css in the js? I'm happy to take this on.

@mreinstein
Copy link
Contributor

I've got a PR that injects the css into the document head, open for improvement suggestions if this is something we'd find useful.

@samthor
Copy link
Contributor

samthor commented Oct 21, 2019

@mreinstein happy to accept PR.

@mreinstein
Copy link
Contributor

@samthor this is where we left off #180

@samthor samthor closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants