-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include minified js and css in npm package #138
Comments
It's something I've thought about. I do it for e.g. inert-polyfill, which was created much more recently. QQ: Inert includes the minified CSS inside the minified JS and adds it to the page as needed. Would that be useful for |
Including the CSS in the JS sounds great to me, thanks, and glad you're amenable to this! |
@samthor would you be open to a PR for including minified css in the js? I'm happy to take this on. |
I've got a PR that injects the css into the document head, open for improvement suggestions if this is something we'd find useful. |
@mreinstein happy to accept PR. |
The dialog-polyfill NPM package does not currently include minified versions of the js and css.
As a result, many NPM users, and therefore users of the unpkg.com CDN, pull in unminified versions of these assets into their pages. Would you consider including minified versions in the NPM package?
Thanks for your consideration and for the great work on dialog-polyfill!
The text was updated successfully, but these errors were encountered: