Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findNearestDialog for child of slotted element #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carmour24
Copy link

Fix for issue #217.

A focus event for an element which is a child of a slotted element
will be erroneously reported as not in the topmost dialog. This is
because for the slotted element we should follow assignedSlot rather
than the parentElement or parentNode to get the true hierarchy in
which the elmeent lives. This change adds handling for slotted
elements.

@google-cla
Copy link

google-cla bot commented Jul 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

A focus event for an element which is a child of a slotted element
will be erroneously reported as not in the topmost dialog. This is
because for the slotted element we should follow assignedSlot rather
than the parentElement or parentNode to get the true hierarchy in
which the elmeent lives. This change adds handling for slotted
elements.
@google-cla
Copy link

google-cla bot commented Jul 22, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants