Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT][Missing one implementation] Provide annotations or list of features missing when clicking on a data point on the graph #966

Open
jcscottiii opened this issue Dec 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jcscottiii
Copy link
Collaborator

Requirement: As a user using the missing one implementation graph, it would be great to see the exact features missing instead of just the count.

Things to consider: The missing count for a given date can range between X and XX items.

User journey 1:

  • A user clicks on a data point on the graph
  • A table/list below the graph populates with the features.
  • Each entry has a link to the feature page in the dashboard itself for more information.

Other things to consider:

  • If a user deselects the data point, the table should clear too
@jcscottiii jcscottiii added the enhancement New feature or request label Dec 11, 2024
@jcscottiii jcscottiii changed the title [ENHANCEMENT] Provide annotations or list of features missing when clicking on a data point on the graph [ENHANCEMENT][Missing one implementation] Provide annotations or list of features missing when clicking on a data point on the graph Dec 11, 2024
@jcscottiii
Copy link
Collaborator Author

Maybe the query should look like this:

SELECT
  releases.EventReleaseDate,
  (
  SELECT
        IFNULL(ARRAY_AGG(STRUCT(wf.FeatureKey,
        wf.Name)), []) As Details,
    -- COUNT(DISTINCT bfse.WebFeatureID) AS Details
  FROM
    BrowserFeatureSupportEvents bfse
  INNER JOIN
    WebFeatures wf
  ON
    wf.ID = bfse.WebFeatureID
  WHERE
    bfse.EventReleaseDate = releases.EventReleaseDate
    AND bfse.TargetBrowserName = 'chrome'
    AND bfse.SupportStatus = 'unsupported'
    AND EXISTS (
    SELECT
      1
    FROM
      BrowserFeatureSupportEvents bfse_other
    WHERE
      bfse_other.WebFeatureID = bfse.WebFeatureID
      AND bfse_other.TargetBrowserName = 'safari'
      AND bfse_other.SupportStatus = 'supported'
      AND bfse_other.EventReleaseDate = bfse.EventReleaseDate )
    AND EXISTS (
    SELECT
      1
    FROM
      BrowserFeatureSupportEvents bfse_other
    WHERE
      bfse_other.WebFeatureID = bfse.WebFeatureID
      AND bfse_other.TargetBrowserName = 'firefox'
      AND bfse_other.SupportStatus = 'supported'
      AND bfse_other.EventReleaseDate = bfse.EventReleaseDate ) ) AS Details
FROM (
  SELECT
    DISTINCT ReleaseDate AS EventReleaseDate
  FROM
    BrowserReleases
  WHERE
    BrowserName IN UNNEST(['chrome', 'safari', 'firefox'])
    AND ReleaseDate >= '2020-01-01'
    AND ReleaseDate < '2025-01-01'
    AND ReleaseDate < CURRENT_TIMESTAMP() ) releases
ORDER BY
  releases.EventReleaseDate DESC
LIMIT
  100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant