align network module with BiDi spec

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network

Author: Thiago Perrotta

Diff for: src/bidiMapper/domains/network/networkRequest.ts

@@ -161,7 +161,7 @@ export class NetworkRequest {
     };
   }
 
-  #getBaseEventParams(): Network.BaseEventParams {
+  #getBaseEventParams(): Network.BaseParameters {
     return {
       context: this.#requestWillBeSentEvent?.frameId ?? null,
       navigation: this.#requestWillBeSentEvent?.loaderId ?? null,
@@ -221,8 +221,6 @@ export class NetworkRequest {
         // TODO: implement.
         tlsStart: 0,
         // TODO: implement.
-        tlsEnd: 0,
-        // TODO: implement.
         requestStart: 0,
         // TODO: implement.
         responseStart: 0,
@@ -309,7 +307,6 @@ export class NetworkRequest {
           fromCache:
             this.#responseReceivedEvent.response.fromDiskCache ||
             this.#responseReceivedEvent.response.fromPrefetchCache,
-          // TODO: implement.
           headers: this.#getHeaders(
             this.#responseReceivedEvent.response.headers
           ),

Diff for: src/protocol/protocol.ts

@@ -32,6 +32,7 @@ export interface EventResponse<MethodType, ParamsType> {
 export type BiDiCommand =
   | BrowsingContext.Command
   | CDP.Command
+  | Network.Command
   | Script.Command
   | Session.Command;
 
@@ -51,6 +52,7 @@ export namespace Message {
   export type CommandRequest = Pick<RawCommandRequest, 'id'> & BiDiCommand;
   export type CommandResponse = Pick<RawCommandRequest, 'id'> & ResultData;
 
+  export type EmptyCommand = never;
   export type EmptyParams = Record<string, never>;
   export type EmptyResult = {result: Record<string, never>};
 
@@ -60,6 +62,7 @@ export namespace Message {
     | BrowsingContext.Result
     | CDP.Result
     | ErrorResult
+    | Network.Result
     | Script.Result
     | Session.Result;
   // keep-sorted end
@@ -1018,9 +1021,14 @@ export namespace Log {
 }
 
 export namespace Network {
+  export type Command = Message.EmptyCommand;
+
+  export type Result = Message.EmptyResult;
+
   export type Event =
     | BeforeRequestSentEvent
     | ResponseCompletedEvent
+    | ResponseStartedEvent
     | FetchErrorEvent;
 
   export type BeforeRequestSentEvent = EventResponse<
@@ -1033,6 +1041,11 @@ export namespace Network {
     ResponseCompletedParams
   >;
 
+  export type ResponseStartedEvent = EventResponse<
+    EventNames.ResponseStartedEvent,
+    ResponseStartedParams
+  >;
+
   export type FetchErrorEvent = EventResponse<
     EventNames.FetchErrorEvent,
     FetchErrorParams
@@ -1068,12 +1081,13 @@ export namespace Network {
     connectStart: number;
     connectEnd: number;
     tlsStart: number;
-    tlsEnd: number;
     requestStart: number;
     responseStart: number;
     responseEnd: number;
   };
 
+  export type Request = string;
+
   export type RequestData = {
     request: string;
     url: string;
@@ -1085,8 +1099,8 @@ export namespace Network {
     timings: FetchTimingInfo;
   };
 
-  export type BaseEventParams = {
-    context: string | null;
+  export type BaseParameters = {
+    context: CommonDataTypes.BrowsingContext | null;
     navigation: BrowsingContext.Navigation | null;
     redirectCount: number;
     request: RequestData;
@@ -1119,24 +1133,29 @@ export namespace Network {
     content: ResponseContent;
   };
 
-  export type BeforeRequestSentParams = BaseEventParams & {
+  export type BeforeRequestSentParams = BaseParameters & {
     initiator: Initiator;
   };
 
-  export type ResponseCompletedParams = BaseEventParams & {
+  export type ResponseCompletedParams = BaseParameters & {
     response: ResponseData;
   };
 
-  export type FetchErrorParams = BaseEventParams & {
+  export type ResponseStartedParams = BaseParameters & {
+    response: ResponseData;
+  };
+
+  export type FetchErrorParams = BaseParameters & {
     errorText: string;
   };
 
   export const AllEvents = 'network';
 
   export enum EventNames {
     BeforeRequestSentEvent = 'network.beforeRequestSent',
-    ResponseCompletedEvent = 'network.responseCompleted',
     FetchErrorEvent = 'network.fetchError',
+    ResponseStartedEvent = 'network.responseStarted',
+    ResponseCompletedEvent = 'network.responseCompleted',
   }
 }