Skip to content

Commit dd8c6bf

Browse files
author
Thiago Perrotta
committed
align network module with BiDi spec and scaffold responseStarted
Bug: #765 Spec: https://w3c.github.io/webdriver-bidi/#module-network
1 parent 4806cb6 commit dd8c6bf

File tree

12 files changed

+248
-184
lines changed

12 files changed

+248
-184
lines changed

Diff for: src/bidiMapper/domains/events/SubscriptionManager.spec.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -451,8 +451,9 @@ describe('unroll events', () => {
451451
it('all Network events', () => {
452452
expect(unrollEvents([Network.AllEvents])).to.deep.equal([
453453
Network.EventNames.BeforeRequestSentEvent,
454-
Network.EventNames.ResponseCompletedEvent,
455454
Network.EventNames.FetchErrorEvent,
455+
Network.EventNames.ResponseStartedEvent,
456+
Network.EventNames.ResponseCompletedEvent,
456457
]);
457458
});
458459

Diff for: src/bidiMapper/domains/network/networkProcessor.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import Protocol from 'devtools-protocol';
2525
import {CdpClient} from '../../CdpConnection.js';
2626
import {IEventManager} from '../events/EventManager.js';
2727
import {DefaultMap} from '../../../utils/DefaultMap.js';
28+
import {Network} from '../../../protocol/protocol.js';
2829

2930
import {NetworkRequest} from './networkRequest.js';
3031

@@ -35,11 +36,11 @@ export class NetworkProcessor {
3536
* Map of request ID to NetworkRequest objects. Needed as long as information
3637
* about requests comes from different events.
3738
*/
38-
readonly #requestMap: DefaultMap<string, NetworkRequest>;
39+
readonly #requestMap: DefaultMap<Network.Request, NetworkRequest>;
3940

4041
private constructor(eventManager: IEventManager) {
4142
this.#eventManager = eventManager;
42-
this.#requestMap = new DefaultMap<string, NetworkRequest>(
43+
this.#requestMap = new DefaultMap(
4344
(requestId) => new NetworkRequest(requestId, this.#eventManager)
4445
);
4546
}
@@ -109,7 +110,7 @@ export class NetworkProcessor {
109110
return networkProcessor;
110111
}
111112

112-
#getOrCreateNetworkRequest(requestId: string): NetworkRequest {
113+
#getOrCreateNetworkRequest(requestId: Network.Request): NetworkRequest {
113114
return this.#requestMap.get(requestId);
114115
}
115116
}

0 commit comments

Comments
 (0)