Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network idle callback demo not working #5

Closed
jadjoubran opened this issue Dec 5, 2018 · 4 comments
Closed

network idle callback demo not working #5

jadjoubran opened this issue Dec 5, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@jadjoubran
Copy link
Collaborator

It seems the error is from the module.export in the network idle callback loaded from unpkg
(https://unpkg.com/[email protected]/lib/index.js)

screen shot 2018-12-05 at 17 35 37
screen shot 2018-12-05 at 17 35 49

@jadjoubran jadjoubran added the bug Something isn't working label Dec 5, 2018
@addyosmani
Copy link
Collaborator

Thanks for filing this, @jadjoubran. I also discovered some other path related issues that I've filed upstream in pastelsky/network-idle-callback#1.

I'm wondering what the fix to request here is. When I locally drop the module.exports = {... } block everything appears to be working correctly. Perhaps we ask the author to vend a UMD build in addition to CJS?

@addyosmani
Copy link
Collaborator

@jadjoubran This should be fixed now. If you get a chance, could you verify there aren't further bugs you're experiencing? Cheers!

@jadjoubran
Copy link
Collaborator Author

Confirmed it's working 👍

@addyosmani
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants