From ce77cac440a9e8778a23ea504a888790f07a7c86 Mon Sep 17 00:00:00 2001 From: Andrew Peabody Date: Tue, 12 Nov 2024 13:02:01 -0800 Subject: [PATCH] fix(dev-tools): make, not bash (#2691) --- .github/workflows/build-push-cft-devtools.yml | 1 + infra/build/Makefile | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-push-cft-devtools.yml b/.github/workflows/build-push-cft-devtools.yml index d79f37ee682..e14fffa679e 100644 --- a/.github/workflows/build-push-cft-devtools.yml +++ b/.github/workflows/build-push-cft-devtools.yml @@ -18,6 +18,7 @@ jobs: permissions: contents: 'read' id-token: 'write' + issues: 'write' steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/infra/build/Makefile b/infra/build/Makefile index 0b310d2d81b..38a815a2203 100644 --- a/infra/build/Makefile +++ b/infra/build/Makefile @@ -115,10 +115,7 @@ build-image-developer-tools: .PHONY: release-image-developer-tools release-image-developer-tools: - if [[ -z "${GITHUB_SHA}" ]]; then - echo "ERROR: Missing GITHUB_SHA for the release" - exit 1 - fi + test -n "$(GITHUB_SHA)" # $$GITHUB_SHA docker tag ${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS} \ ${REGISTRY_URL}/${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS}