Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint pipelines does not fail in some cases #1817

Closed
bharathkkb opened this issue Sep 7, 2023 · 4 comments
Closed

Lint pipelines does not fail in some cases #1817

bharathkkb opened this issue Sep 7, 2023 · 4 comments
Labels
Stale

Comments

@bharathkkb
Copy link
Member

A readme diff was introduced but the workflow run reported diff but didn't fail the pipeline.
@bharathkkb
Copy link
Member Author

Maybe fixed by #1484?

@apeabody
Copy link
Collaborator

apeabody commented Sep 7, 2023

Very likely as I believe the issue was introduced in 1.9 and that fix landed in 1.11.3. The repo is still on 1.10: terraform-google-modules/terraform-google-vm#304

@bharathkkb bharathkkb mentioned this issue Sep 20, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Nov 6, 2023
@bharathkkb
Copy link
Member Author

Havent seen this happen after fix above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bharathkkb @apeabody