Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-google-audiences list ignored #825

Open
gombasp opened this issue Jun 16, 2023 · 3 comments
Open

x-google-audiences list ignored #825

gombasp opened this issue Jun 16, 2023 · 3 comments

Comments

@gombasp
Copy link

gombasp commented Jun 16, 2023

Hi,

ESPv2 seems to be ignoring the list in x-google-audiences. In ESPv1 we used to have lists of allowed audiences and for me it seems its not working any more with v2.
For example if you have a service: https://aservice.mydevelopment.cloud.goog

...and you define your endpoint to use:

"google_id_token" : {
"type" : "oauth2",
"authorizationUrl" : "",
"flow" : "implicit",
"x-google-issuer" : "https://accounts.google.com",
"x-google-jwks_uri" : "https://www.googleapis.com/oauth2/v3/certs",
"x-google-audiences" : "https://aservice.mydevelopment.cloud.goog,https://bservice.mydevelopment.cloud.goog,https://cservice.mydevelopment.cloud.goog"
}

...then it would work only if you use https://aservice.mydevelopment.cloud.goog aud in the jwt.

Please advise - thanks.

@gombasp
Copy link
Author

gombasp commented Jun 19, 2023

Additional info: tested wit 2.44.0

@gombasp
Copy link
Author

gombasp commented Jun 21, 2023

Additional info: running on GKE

@gombasp
Copy link
Author

gombasp commented Jun 21, 2023

False alarm, was incorrectly tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant