From 69ee3a78b4aa110a63e71ad34da2704b98bbb6ee Mon Sep 17 00:00:00 2001 From: Jingyi Hu Date: Thu, 12 Dec 2024 19:00:30 +0000 Subject: [PATCH] tool: remove redundant flag validation --- .../generatecontroller/generatecontrollercommand.go | 6 ------ .../pkg/commands/generatedirectreconciler/command.go | 6 ------ 2 files changed, 12 deletions(-) diff --git a/dev/tools/controllerbuilder/pkg/commands/generatecontroller/generatecontrollercommand.go b/dev/tools/controllerbuilder/pkg/commands/generatecontroller/generatecontrollercommand.go index b5cedefbcaa..cfdab7f5cc1 100644 --- a/dev/tools/controllerbuilder/pkg/commands/generatecontroller/generatecontrollercommand.go +++ b/dev/tools/controllerbuilder/pkg/commands/generatecontroller/generatecontrollercommand.go @@ -48,12 +48,6 @@ func BuildCommand(baseOptions *options.GenerateOptions) *cobra.Command { if opt.Resource == (options.Resource{}) { return fmt.Errorf("--resource flag is required") } - if opt.Resource.Kind == "" { - return fmt.Errorf("need to specify KRM Kind in --resource") - } - if opt.Resource.ProtoName == "" { - return fmt.Errorf("need to specify proto resource name in --resource") - } if baseOptions.APIVersion == "" { return fmt.Errorf("--api-version is required") diff --git a/dev/tools/controllerbuilder/pkg/commands/generatedirectreconciler/command.go b/dev/tools/controllerbuilder/pkg/commands/generatedirectreconciler/command.go index a77e2d6cc29..13bb79621bd 100644 --- a/dev/tools/controllerbuilder/pkg/commands/generatedirectreconciler/command.go +++ b/dev/tools/controllerbuilder/pkg/commands/generatedirectreconciler/command.go @@ -72,12 +72,6 @@ func BuildCommand(baseOptions *options.GenerateOptions) *cobra.Command { if opt.Resource == (options.Resource{}) { return fmt.Errorf("--resource flag is required") } - if opt.Resource.Kind == "" { - return fmt.Errorf("need to specify KRM Kind in --resource") - } - if opt.Resource.ProtoName == "" { - return fmt.Errorf("need to specify proto resource name in --resource") - } if baseOptions.APIVersion == "" { return fmt.Errorf("--api-version is required")