Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use comment.CompareProtoMessage for early direct resources #3347

Open
acpana opened this issue Dec 10, 2024 · 0 comments
Open

refactor: use comment.CompareProtoMessage for early direct resources #3347

acpana opened this issue Dec 10, 2024 · 0 comments

Comments

@acpana
Copy link
Collaborator

acpana commented Dec 10, 2024 •
edited
Loading

For early direct resources, we might've spelled out the comparisons. In contrast, now we have a more automated, compact function to compare diffs.

          Suggest using `comment.CompareProtoMessage`

Originally posted by @yuwenma in #2993 (comment)
@acpana acpana changed the title refactor: use comment.CompareProtoMessage for old direct resources refactor: use comment.CompareProtoMessage for early direct resources Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acpana