Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Cannot configure healthcheck #135

Open
brndnmtthws opened this issue Feb 15, 2018 · 6 comments
Open

Cannot configure healthcheck #135

brndnmtthws opened this issue Feb 15, 2018 · 6 comments

Comments

@brndnmtthws
Copy link

The default healthcheck settings aren't optimal, and I have to edit the source code to change them, or change them manually through the API. It'd be nice to be able to configure the health checks so I can use more reasonable values (5s interval, with 2 checks to change state).

@G-Harmon
Copy link
Contributor

@csbell had asked me to to file an Issue about being able to configure health check timeouts. You beat me to it, Brenden.

@nikhiljindal
Copy link
Contributor

I can see 2 aspects to this:

  • The current defaults in code are not optimal and we should fix them.
  • Or you have a custom setup and we should provide a way to override the defaults.

Both are valuable and we should fix both, but am curious which bucket do you think you fall into?
Also will be great if you can share some more context on why the current defaults dont work for you. Scenarios in which they break. Are they too high/short?
Thanks!

@brndnmtthws
Copy link
Author

In my case it's the first issue. The defaults that GCP provides are better IMO (which is a 5 second interval with 2 up and 2 down). I don't have anything special other than I think 600 seconds (10 minutes) is far too long for detecting failures (which is how long 10 failures takes to detect with a 60s interval). With the GCP default it'll only take about 10s.

@dicarlo2
Copy link

dicarlo2 commented Mar 6, 2018

+1 for configuring health checks. Ideally it would just work based on the underlying service/pod’s health checks. IIRC this is how the normal gce ingress works as well as the federation ingress (though I could be wrong)

@borjagarciamrf
Copy link

+1 600 seconds it's a long time.
+1 honouring underlying service/pod’s health checks

@bigmyx
Copy link

bigmyx commented May 6, 2020

Is it possible to modify the healthcheck probe to use TCP vs. HTTP request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants